Add csst-at-extension#193
Closed
TOR968 wants to merge 1 commit into
Closed
Conversation
Member
|
We are choosing to deny this plugin. It is overly complicated for what it is trying to accomplish, and the codebase has the same issues as the last reviewal. For a plugin like this, you'd simply need a webkit - I'm not 100% sure why you have this whole "injection" setup. |
Contributor
Author
|
@shdwmtr The whole problem is that the plugins weren't working for several weeks because of WebKit. I reworked everything to use injection, but when I started creating a PR, WebKit started working again. To avoid having to delete what I'd already done, I added an option to choose between them—WebKit is set as the default, and CDP is there as a backup in case it stops working again. The system load is the same as what I saw in the Millennium Plugins menu. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CSST.at
plugin that injects a csst.at profile button into Steam community profile pages
Task Checklist
Developer
Plugin Functionality
Backend Configuration
Community Contribution
Testing Instructions